Skip to content

fix(gatsby-source-filesystem): Update typings for createRemoteFileNode - #24750

Merged
gatsbybot merged 1 commit into
masterfrom
vladar/gh-24735
Jun 16, 2020
Merged

fix(gatsby-source-filesystem): Update typings for createRemoteFileNode#24750
gatsbybot merged 1 commit into
masterfrom
vladar/gh-24735

Conversation

@vladar

@vladar vladar commented Jun 3, 2020

Copy link
Copy Markdown
Contributor

Description

This PR fixes broken typings of createRemoteFileNode (in gatsby-source-filesystem).

Using NodePluginArgs["cache"] instead of GatsbyCache because it is compatible with both - new and old versions of gatsby. Using GatsbyCache will only work with gatsby@^2.22.13 and will break with older versions.

Documentation

N/A

Related Issues

Fixes #24735

@vladar
vladar requested a review from a team June 3, 2020 12:41
@gatsbot gatsbot Bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 3, 2020
@vladar vladar added status: needs core review Currently awaiting review from Core team member and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jun 3, 2020
@vladar vladar added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jun 16, 2020
@gatsbybot
gatsbybot merged commit c9a24f9 into master Jun 16, 2020
@delete-merged-branch
delete-merged-branch Bot deleted the vladar/gh-24735 branch June 16, 2020 13:04
raffishquartan pushed a commit to raffishquartan/gatsby that referenced this pull request Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot: merge on green Gatsbot will merge these PRs automatically when all tests passes status: needs core review Currently awaiting review from Core team member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Types for CreateRemoteFileNodeArgs['cache'] are inconsistent with Gatsby types

4 participants