Skip to content

Conversation

@miracle2k
Copy link

Description

Fixes #19055 and allows the shopify plugin to work with shops that run on a custom domain.

See the ticket for a discussion of the issue.

@miracle2k miracle2k requested review from a team December 18, 2019 23:28
@monizb monizb added type: bug An issue or pull request relating to a bug in Gatsby type: documentation An issue or pull request for improving or updating Gatsby's documentation effort: low breaking change If implemented, this proposed work would break functionality for older versions of Gatsby labels Dec 19, 2019
Copy link
Contributor

@pvdz pvdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update to use includes and test both cases. Thank you :)

@pvdz
Copy link
Contributor

pvdz commented Dec 19, 2019

Can you elaborate on why this is a breaking change? I'm assuming shopify domains that are not custom cannot have dots in their name?

@miracle2k
Copy link
Author

As per the discussion in the ticket (dots not allowed in the shop name) I don't think this is a breaking change. @monizb added the label.

@pieh pieh removed the breaking change If implemented, this proposed work would break functionality for older versions of Gatsby label Dec 19, 2019
@monizb
Copy link
Contributor

monizb commented Dec 19, 2019

Hey!
Really sorry for the wrong label, must have mis-clicked it :)

@lannonbr lannonbr changed the title Add support for custom domains to gatsby-source-shopify feat(gatsby-source-shopify): Add support for custom domains Dec 19, 2019
@lannonbr lannonbr removed the type: documentation An issue or pull request for improving or updating Gatsby's documentation label Dec 19, 2019
@pvdz
Copy link
Contributor

pvdz commented Dec 20, 2019

Awesome. Thanks!

@pvdz pvdz merged commit 11fe33f into gatsbyjs:master Dec 20, 2019
@gatsbot
Copy link

gatsbot bot commented Dec 20, 2019

Holy buckets, @miracle2k — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug An issue or pull request relating to a bug in Gatsby

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gatsby-source-shopify does not allow a custom shopify domain

5 participants