-
Notifications
You must be signed in to change notification settings - Fork 10.3k
feat(gatsby-source-shopify): Add support for custom domains #20204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pvdz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update to use includes and test both cases. Thank you :)
|
Can you elaborate on why this is a breaking change? I'm assuming shopify domains that are not custom cannot have dots in their name? |
|
As per the discussion in the ticket (dots not allowed in the shop name) I don't think this is a breaking change. @monizb added the label. |
|
Hey! |
|
Awesome. Thanks! |
|
Holy buckets, @miracle2k — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
Description
Fixes #19055 and allows the shopify plugin to work with shops that run on a custom domain.
See the ticket for a discussion of the issue.