-
Notifications
You must be signed in to change notification settings - Fork 10.3k
using-javascript-transforms location error #1547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@KyleAMathews this fixes the error mentioned in #1492. |
|
Deploy preview ready! Built with commit 3b808a3 |
|
Deploy preview ready! Built with commit 3b808a3 |
|
Deploy preview ready! Built with commit 3b808a3 |
|
The site builds now! But looks like it's missing CSS somehow https://596ea4f2cf321c3016b61529--using-javascript-transforms.netlify.com/ |
|
It is throwing a minified react error.... hmm.... I think the error is just breaking the scss import here. This would be more helpful if it showed up in develop :) |
|
The error is the following for future self: |
|
I am still getting a minified react error even removing anything that seems like uglification. I started to dig into the chrome dev tools, and paused on exception. The following is the stack trace. The page component fails on line one, and the next two files are within the core. for bootstrap, line 20 is the third line: The webpack footer for patch is: If I click the patch.js, the stack changes and everything and including this file say line 96, but the file only goes up to line 95. Long story short, I don't see any code I recognize. |
|
Deploy preview failed. Built with commit 31a110b https://app.netlify.com/sites/using-styled-components/deploys/597160867960b106d8991702 |
|
well jeez, I figured out the minification error... on another note, the styles still don't import on build. |
|
Deploy preview failed. Built with commit 31a110b https://app.netlify.com/sites/image-processing/deploys/597160867960b106d89916fc |
|
Deploy preview failed. Built with commit 31a110b https://app.netlify.com/sites/using-remark/deploys/597160877960b106d8991708 |
|
Deploy preview failed. Built with commit 31a110b https://app.netlify.com/sites/using-glamor/deploys/597160867960b106d89916ff |
|
Deploy preview failed. Built with commit 31a110b https://app.netlify.com/sites/using-postcss-sass/deploys/597160867960b106d89916f6 |
|
Deploy preview failed. Built with commit 31a110b https://app.netlify.com/sites/using-contentful/deploys/597160867960b106d8991705 |
|
I think we can just merge this and I will clean up the the remaining component error in another PR since I fixed the root issues for the initial reason for the PR. |
KyleAMathews
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's some conflicts as well that need resolved.
Also you said the layout query was causing trouble and should be removed?
| import * as PropTypes from "prop-types" | ||
| import Helmet from 'react-helmet'; | ||
|
|
||
| let stylesStr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about you just remove this file altogether and use the default html.js? It already has inlining of css setup, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me. Deleted.
|
@jbolda could you get this example site fixed up? It's broken still which means our Netlify check is failing every time. |
|
I don't know what the deal with the conflicts were. It was the exact same code in master vs my branch. shrugs |
|
@KyleAMathews I certainly hope that is everything! Turns out the "missing" page error that only shows up in build/serve is because I didn't have trailing slashes. |
|
Looks like Netlify is happy now! thanks! |
Turns out the error only showed up on build. Too many refactors and I forgot that to update that
locationwas expected onthis.props.