Call next() after serving HTML #1349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Deploy preview ready! Built with commit d20629e |
Collaborator
|
Deploy preview ready! Built with commit d20629e |
Collaborator
|
Deploy preview ready! Built with commit d20629e |
Contributor
|
Does this need to be in an else? Or does calling next have no effect if you've already responded? Don't use express much :-) |
Contributor
Author
|
Looking at the docs I think it's a no-op but will put it in an
|
Contributor
Author
|
Commit updated. |
Contributor
|
Thanks for the quick fix! |
This was referenced Apr 20, 2021
This was referenced Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1348
Introduced in #1324