feat(redirects): handle absolute from paths when path prefix is used #12509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieh
reviewed
Mar 12, 2019
Contributor
pieh
left a comment
pieh
left a comment
There was a problem hiding this comment.
This is looking very nice! I really love comprehensive test suite for this! I have one suggestion just to keep code a little more DRY
Remove duplicated logic and make it as maybeAddPathPrefix.
Contributor
Author
|
@pieh Thanks for the thoughtful review. I updated the code based on your recommendation. Please review the changes when you have time. 😊 |
pieh
changed the title
pieh
approved these changes
Mar 13, 2019
This was referenced May 25, 2021
Open
This was referenced Sep 16, 2021
Open
This was referenced Dec 1, 2021
This was referenced Jun 24, 2023
This was referenced Nov 28, 2023
This was referenced Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
toPathincreateRedirecthandles path prefix properly, however,fromPathdoesn't. I added the code for supporting thefromPathcases.Also, I added test cases of
createRedirectaction for the future.Related Issues
Fixes #12497