Skip to content

Conversation

@parammittal16
Copy link
Contributor

Description

Fixes the visibility of the search placeholder on home and other pages.

Before
52912001-607eff00-32d1-11e9-9d08-16aec5b74da3
52911998-58bf5a80-32d1-11e9-80a4-88d4be58466a

After
after
after2

Related Issues

Fixes #9694

@parammittal16 parammittal16 requested a review from a team February 18, 2019 07:39
@parammittal16
Copy link
Contributor Author

@KyleAMathews @DSchau Plz review this.

Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not able to replicate the issue, but it seems that others in the original issue are able to, so we can merge this.

Thanks!

@DSchau DSchau merged commit 8ba724f into gatsbyjs:master Feb 20, 2019
@gatsbot
Copy link

gatsbot bot commented Feb 20, 2019

Holy buckets, @parammittal16 — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@parammittal16
Copy link
Contributor Author

Thank you So Much @DSchau :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search bar not showing full placeholder!

2 participants