[1.0] GraphQL connection operator name tweaks fixes #1174 #1177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Deploy preview ready! Built with commit 47955d0 |
Collaborator
|
Deploy preview ready! Built with commit 47955d0 |
Collaborator
|
Deploy preview failed. Built with commit 47955d0 https://app.netlify.com/sites/gatsbyjs/deploys/5942d8c3cf321c4b3c3f1a33 |
…ilter' This both makes it easier to navigate the connection arguments as well as protects against name collisions as if someone had a filter named skip, limit, or sort (the other top-level input fields) then there'd be a mysterious error.
Contributor
Author
|
I also decided to rename the connection field "groupBy" to group for the same reason as sortBy -> sort. |
Contributor
Author
|
From the last commit, more of the rational for the filter change:
|
KyleAMathews
changed the title
This was referenced Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.