[Site Showcase] Adding Dan Abramov's personal blog #10241
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saw his post on Twitter so i thought it might be great to add his new blog to the showcase Questions though: - What's the rule on posting other people's site? - Should we ask Dan for permission first before adding it?
|
Danger run resulted in 1 warning; to find out more, see the checks page. Generated by 🚫 dangerJS |
Contributor
|
Generally you shouldn't add someone's personal blog without permission as individuals should be able to make that decision. Corporate sites are ok. We can ask him here though — @gaearon — would adding your blog to the gatsby site showcase be ok? https://www.gatsbyjs.org/showcase/ |
Contributor
Author
|
Understood 👍 |
Contributor
|
Closing this PR then since he didn't answer to this. If he wants it added at some later point he can open up a new PR 👍 |
|
I don't mind |
This was referenced Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saw his post on Twitter so i thought it might be great to add his new blog to the showcase
Questions though: