-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Description
Description
gatsby-plugin-emotion 4.0.2 is breaking builds where 4.0.1 succeeded. It appears some old files from 3.x (gatsby-browser.js, gatsby-ssr.js, and wrap-element.js) somehow made it into the published package. These files were deleted in #10500.
Compare 4.0.1 to 4.0.2 on unpkg:
https://unpkg.com/[email protected]/ (correct)
https://unpkg.com/[email protected]/ (incorrect)
Looks like they also snuck into the 4.0.0 build somehow, then were removed in 4.0.1, but now they're back. These things just won't die! 💀
Steps to reproduce
Happy to make a reproduction repo if helpful, but doesn't seem valuable for this particular issue.
Expected result
I would expect only the current files to be in the corresponding published package.
Actual result
Additional files (not in the current source tree) are being included in the published package.
error Generating JavaScript bundles failed
Error: ./node_modules/gatsby-plugin-emotion/wrap-element.js
Module not found: Error: Can't resolve 'emotion' in '/project/node_modules/gatsby-plugin-emotion'
Environment
System:
OS: macOS 10.14.2
CPU: (12) x64 Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 11.7.0 - /usr/local/bin/node
Yarn: 1.13.0 - /usr/local/bin/yarn
npm: 6.5.0 - /usr/local/bin/npm
Languages:
Python: 2.7.15 - /usr/local/bin/python
Browsers:
Chrome: 71.0.3578.98
Firefox: 61.0.2
Safari: 12.0.2
npmPackages:
gatsby: 2.0.110 => 2.0.110
gatsby-plugin-emotion: 4.0.2 => 4.0.2
gatsby-plugin-manifest: 2.0.17 => 2.0.17
gatsby-plugin-netlify: 2.0.8 => 2.0.8
gatsby-plugin-offline: 2.0.22 => 2.0.22
gatsby-plugin-react-helmet: 3.0.6 => 3.0.6
gatsby-plugin-typescript: 2.0.6 => 2.0.6