fix(rss): generate slug for rss #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| exports.onCreateNode = ({ node, boundActionCreators, getNode }) => { | ||
| const { createNodeField } = boundActionCreators |
Contributor
There was a problem hiding this comment.
Author
There was a problem hiding this comment.
@KyleAMathews Are you referring to https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby-source-filesystem/src/create-file-path.js#L35-L46, as a suggestion for what should be implemented here?
Contributor
There was a problem hiding this comment.
No use it directly. The function is exported from gatsby-source-filesystem and intended to be used for creating slugs from files.
Author
|
@KyleAMathews Take a look now and let me know what you think. |
Contributor
|
Looks great! |
Contributor
|
Did a bit more work to make it use the new auto-generated slugs instead of the path from the frontmatter 6d51a2c |
Author
|
@KyleAMathews Looks good! 👍 |
restato
pushed a commit
to restato/gatsby-starter-blog
that referenced
this pull request
Jun 30, 2019
add link to bottom of RSS feed articles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should allow the RSS plugin, applied in #68, to run cleanly.