command SETUP_FILAMENT doesn't seem to take strings in arbitrary args

[Nathan22211]

I'm using danger klipper, which has PID profiles, and I was trying to set the pid profile of a filament like this SETUP_FILAMENT name=abs extruder=260 bed=105 chamber=60 pid=abs pa_inner_wall=0.02 pa_outer_wall=0.035 pa_infill=0.0 however, I get an error message in console saying Unable to parse 'abs' as a Python literal

[garethky]

You'll have to quote the strings: pid='abs'

Unfortunately Klipper can't guess the types of the extra arguments so they have to be valid Python code. Bare strings without the quotes are not valid Python. The name= parameter is known to be a string so the quotes can be omitted on that one.

[Nathan22211]

yeah I did pid='abs' and I still get the error

[garethky]

Hmm, might need double quotes? pid="abs"

[Nathan22211]

Pretty sure I tried that too. Python doesn't differentiate between single and double quotes to begin with so I doubt that makes a difference

…

On Sun, May 19, 2024, 4:40 PM Gareth Farrington ***@***.***> wrote: Hmm, might need double quotes? pid="abs" — Reply to this email directly, view it on GitHub <#4 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIM3Y3FP3KPSLDQOX53BV7DZDEL3PAVCNFSM6AAAAABH5K3DVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJZGM3DONZZGE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[garethky]

Ahh, i forgot how this works. This is what you have to do:

SETUP_FILAMENT NAME=PLA EXTRUDER=215 BED=60 FOO="'bar'"

Unfortunately, that's just how macro argument handling works in klipper, nothing I can really do to make that nicer.

I did a post about python literals a long time ago: https://klipper.discourse.group/t/macro-creation-tutorial/30/20
You need the outside set of quotes to stop the gcode parser assuming that the text is part of the rest of the command. Then you need the inside quotes to actually make it a python string literal.