Fix `FileString~ for string > 2G (#862 for stable-4.8) #875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far, `FileString` only wrote files < 2G and did not indicate an error in case of larger strings. With this fix strings of any length can be written and in case of a failure the corresponding system error is shown.
Same problem as for FileString in the code which tried to read the whole
file in one chunk. On some (all?) systems this cannot be done if file is
> 2G.
Testfiles should not have code that deals with such big files and strings.
So, here is some example code:
ll:=List([0..255], CHAR_INT);;
smp := "";;
for i in [1..1000000] do Add(smp,Random(ll)); od;
s := "";;
while Length(s) < 2^31+2^28 do
Append(s, smp{[Random(1,300000)..Random(700000,1000000)]});
od;
Length(s);
FileString("/cache/check", s);
Exec("ls -l /cache/check");
s2 := StringFile("/cache/check");;
Length(s2);
s = s2;
Member
|
@markuspf @frankluebeck this causes warnings when building on Windows: |
Member
|
@alex-konovalov : since you have a compiler for Windows it would be good it you could fix (and test) this yourself. Hint: I think the Windows code of this function does not need a fix. Maybe you can also check this on Windows, there is example input in the discussion of the original pull request #862. |
Member
|
@frankluebeck thanks, I will (I don't have a working development environment, but I can login into a Jenkins node and check). |
This was referenced Aug 12, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was submitted as #862 on the master branch.
Description of changes (for the release notes)
So far, FileString only wrote files < 2G and did not indicate
an error in case of larger strings.
With this fix strings of any length can be written and in case of a failure
the corresponding system error is shown.