Skip to content

WeakPointer: Check for exclusive write access in LengthWPObj #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markuspf merged 1 commit into from
Mar 18, 2015
Merged

WeakPointer: Check for exclusive write access in LengthWPObj #78

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 17 additions & 15 deletions src/weakptr.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,32 +200,34 @@ Obj FuncWeakPointerObj( Obj self, Obj list ) {
** trailing items may evaporate.
**
** Any identifiers of trailing objects that have evaporated in a garbage
** collection are cleaned up by this function
** collection are cleaned up by this function, if we have exclusive
** write access, otherwise they stay around.
*/

Int LengthWPObj(Obj wp)
{
Int len;
Obj elm;
Int changed = 0;
len = STORED_LEN_WPOBJ(wp);
if (CheckExclusiveWriteAccess(wp)) {
#ifndef BOEHM_GC
for (len = STORED_LEN_WPOBJ(wp);
len > 0 &&
(!(elm = ELM_WPOBJ(wp,len)) ||
IS_WEAK_DEAD_BAG(elm));
len --)
{
for (; len > 0 &&
(!(elm = ELM_WPOBJ(wp,len)) ||
IS_WEAK_DEAD_BAG(elm));
len --)
{
changed = 1;
if (elm)
ELM_WPOBJ(wp,len) = 0;
}
#else
while (len > 0 && !ELM_WPOBJ(wp, len)) {
changed = 1;
if (elm)
ELM_WPOBJ(wp,len) = 0;
len--;
}
#else
len = STORED_LEN_WPOBJ(wp);
while (len > 0 && !ELM_WPOBJ(wp, len)) {
changed = 1;
len--;
}
#endif
}
if (changed)
STORE_LEN_WPOBJ(wp,len);
return len;
Expand Down