Only enable GMP C++ interface if a C++ compiler is available #728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
IMHO the fact that c++ is a "soft" requirement for GAP building must be clearly documented. One reason is that some Linux distros don't have c++ bundled within "basic/base" tools, while installing c++ is still totally trivial. |
Member
|
I think this is the right thing to do for now. @fingolfin would you be willing to update INSTALL.md and document this, also with a warning that some packages may be affected by this? I will also modify http://www.gap-system.org/Download/tools.html myself. |
Member
Author
|
@alex-konovalov I will do so now |
Member
Author
|
Hmm, I should also rebase this on stable-4.8 ! Will do so later (and open a new PR). |
This was referenced Apr 15, 2016
fingolfin
force-pushed
the
mh/no-cxx-req
branch
from
58bb698 to
e971309
Compare
Member
Author
|
Closing this in favor of PR #740 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request #399 changed the way we build GMP to enable the C++ interface. Unfortunately, this causes a build failure for people who do not have a C++ compiler installed, yet want to use the GMP shipped with GAP (which currently is the default).
This PR changes the build system to only enable C++ support in GMP if autoconf detects a working C++ compiler. This should have no effect for people who have a C++ compiler installed (the majority, I guess), but removes a nuisance for people who do not have a C++ compiler installed.