Skip to content

Conversation

@fingolfin
Copy link
Member

See issue #470

Note that if this merged, it should be merged both into stable-4.8 and master. And in master, one additional change will be needed, as it also uses ErrorMayQuit in lib/files.gi:46

@fingolfin fingolfin added the gapsagedays2016 Issues and PRs that arose at https://www.gapdays.de/gap-sage-days2016 label Jan 16, 2016
@olexandr-konovalov
Copy link
Member

Before merging into stable-4.8, just to make sure that @ChrisJefferson and @james-d-mitchell are aware of our request to update your profiling and semigroups packages - could you manage this before 1st Feb 2016, please?

@fingolfin
Copy link
Member Author

Perhaps I should not completely remove ErrorMayQuit immediately, instead turning it into a synonym -- and then remove it once profiling and semigroups are adapted. Otherwise, we get a chicken-egg-dependency problem...

@fingolfin
Copy link
Member Author

I just did that. We could now merge this, then coax @james-d-mitchell and @ChrisJefferson to adapt their packages; once they did it, we can remove the alias.

markuspf added a commit that referenced this pull request Jan 18, 2016
lib: rename ErrorMayQuit to ErrorNoReturn
@markuspf markuspf merged commit be3e8b9 into gap-system:stable-4.8 Jan 18, 2016
@fingolfin fingolfin deleted the mh/ErrorNoReturn branch January 27, 2016 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gapsagedays2016 Issues and PRs that arose at https://www.gapdays.de/gap-sage-days2016

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants