Skip to content

Revert accidentally-reintroduced downranking of a MatrixObj method #4237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fingolfin merged 1 commit into from
Feb 1, 2021
Merged

Revert accidentally-reintroduced downranking of a MatrixObj method #4237

fingolfin merged 1 commit into from
Feb 1, 2021

Conversation

@wilfwilson
Copy link
Member

@wilfwilson wilfwilson commented Jan 28, 2021

I can confirm that the Semigroups package works fine with this PR.

@wilfwilson
matobj.gi: revert accidentally-reintroduced downranking
43f1d60 
This related to MatrixObj methods breaking Semigroups package.

This reverts the final remaining change from
commit 6f629ba

This change had already been reverted in
ef9f5ee

But it was reintroduced (I think accidentally?) in
52509bb
@wilfwilson wilfwilson added topic: library release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes labels Jan 28, 2021
@fingolfin fingolfin merged commit 5e5c90a into gap-system:master Feb 1, 2021
@wilfwilson wilfwilson deleted the remove-downrank branch March 25, 2021 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fingolfin fingolfin fingolfin approved these changes

Assignees

No one assigned

Labels

release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes topic: library

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wilfwilson @fingolfin