Skip to content

Conversation

@ChrisJefferson
Copy link
Contributor

This is two tweaks needed for the timer code to pass in cygwin.

  1. Cygwin will sometimes report timers after they are cancelled. When we set the signal handler to default, this caused GAP to exit. Change to ignore instead.

  2. Extend test timeouts

@olexandr-konovalov
Copy link
Member

@ChrisJefferson, I've just pushed extended timeouts too. Happy with yours overwriting mine.

@olexandr-konovalov
Copy link
Member

@ChrisJefferson This is perhaps just the same issue that you observe: happened on a Cygwin-free machine testing the nightly build for Windows:

########> Diff in /cygdrive/C/Users/jenkins/workspace/GAP-dev-windows-test/GAP\
-git-snapshot/tst/testinstall/timeout.tst, line 22:
# Input is:
CallWithTimeoutList(5000,spinFor,[10000,1]);
# Expected output:
fail
# But found:
[ 1 ]
########

@olexandr-konovalov
Copy link
Member

@ChrisJefferson: I hit again this tonight:

########> Diff in /cygdrive/C/Users/jenkins/workspace/GAP-dev-windows-test/GAP\
-git-snapshot/tst/testinstall/timeout.tst, line 22:
# Input is:
CallWithTimeoutList(5000,spinFor,[10000,1]);
# Expected output:
fail
# But found:
[ 1 ]
######## 

Shall we merge this PR and see if it helps?

@ChrisJefferson
Copy link
Contributor Author

Yes, let's do that. I've also extended the timeouts, which also should help in cygwin (just wait for the tests to cycle, as a sanity check)

olexandr-konovalov pushed a commit that referenced this pull request Dec 10, 2015
Two tweaks needed for the timer code to pass in cygwin.
@olexandr-konovalov olexandr-konovalov merged commit 302c6c5 into gap-system:master Dec 10, 2015
@ChrisJefferson ChrisJefferson deleted the timerfix branch April 15, 2016 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants