Skip to content

Fix \< for equal but not identical large integers #3478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fingolfin merged 1 commit into from
May 30, 2019
Merged

Fix \< for equal but not identical large integers #3478

fingolfin merged 1 commit into from
May 30, 2019

Conversation

@fingolfin
Copy link
Member

@fingolfin fingolfin commented May 29, 2019

This is an alternative to PR #3476 which changes less code, which reduces the risk of further regressions.

Fixes #3474
Closes #3476

I have another PR which also simplifies EqInt further, but since that bears again a risk of regressions, I'll submit it separately.

@fingolfin fingolfin added kind: bug Issues describing general bugs, and PRs fixing them kind: bug: wrong result Issues describing bugs that result in mathematically or otherwise wrong results, and PRs fixing them topic: kernel release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes backport-to-4.10 labels May 29, 2019
@coveralls
Copy link

coveralls commented May 29, 2019

Coverage Status

Coverage decreased (-0.0005%) to 85.168% when pulling b03b76d on fingolfin:mh/alternate-LtInt-fix into 5fbcf2b on gap-system:master.

stevelinton
stevelinton approved these changes May 29, 2019
View reviewed changes
Copy link
Contributor

@stevelinton stevelinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this version. When I wrote the other version I couldn't quite see a nice way to restore the symmetry here and it just seemed easier to refactor, but this is quite tidy.

@fingolfin fingolfin merged commit 5d81b55 into gap-system:master May 30, 2019
@fingolfin fingolfin deleted the mh/alternate-LtInt-fix branch May 30, 2019 09:37
@fingolfin
Copy link
Member Author

fingolfin commented Jun 4, 2019

Backported to stable-4.10 in commit 3ad3a2b.

@wilfwilson wilfwilson mentioned this pull request Jun 5, 2019
Closed
@fingolfin fingolfin added this to the GAP 4.10.2 milestone Jun 13, 2019
@olexandr-konovalov olexandr-konovalov added release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Jun 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevelinton stevelinton stevelinton approved these changes

@ChrisJefferson ChrisJefferson Awaiting requested review from ChrisJefferson

Assignees

No one assigned

Labels

kind: bug: wrong result Issues describing bugs that result in mathematically or otherwise wrong results, and PRs fixing them kind: bug Issues describing general bugs, and PRs fixing them release notes: added PRs introducing changes that have since been mentioned in the release notes topic: kernel

Projects

None yet

Milestone

GAP 4.10.2

Development

Successfully merging this pull request may close these issues.

Wrong result from LT for rational numbers!

4 participants

@fingolfin @coveralls @stevelinton @olexandr-konovalov