Skip to content

Export Julia CFLAGS, LDFLAGS, and LIBS to sysinfo.gap #3248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fingolfin merged 1 commit into from
Jan 29, 2019
Merged

Export Julia CFLAGS, LDFLAGS, and LIBS to sysinfo.gap #3248

fingolfin merged 1 commit into from
Jan 29, 2019

Conversation

@sebasguts
Copy link
Member

@sebasguts sebasguts commented Jan 29, 2019

No description provided.

@sebasguts sebasguts requested a review from fingolfin January 29, 2019 12:35
@sebasguts sebasguts mentioned this pull request Jan 29, 2019
Merged
@codecov
Copy link

codecov bot commented Jan 29, 2019 •
edited
Loading

Codecov Report

Merging #3248 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3248      +/-   ##
==========================================
- Coverage   85.09%   85.09%   -0.01%     
==========================================
  Files         695      695              
  Lines      344336   344336              
==========================================
- Hits       293024   293023       -1     
- Misses      51312    51313       +1
Impacted Files Coverage Δ
src/stats.c 94.93% <0%> (-0.21%) ⬇️

@coveralls
Copy link

coveralls commented Jan 29, 2019

Coverage Status

Coverage increased (+0.0002%) to 84.934% when pulling 629febc on sebasguts:sg/export_julia_flags_to_sysinfo into c381e0c on gap-system:master.

@fingolfin fingolfin merged commit e1eb601 into gap-system:master Jan 29, 2019
@fingolfin fingolfin added the topic: julia Julia GC integration and related matters label Jan 29, 2019
@fingolfin
Copy link
Member

fingolfin commented Feb 13, 2019

Backported to stable-4.10 in c67b4f0

@olexandr-konovalov olexandr-konovalov added this to the GAP 4.10.1 milestone Feb 23, 2019
@olexandr-konovalov olexandr-konovalov added the release notes: added PRs introducing changes that have since been mentioned in the release notes label Feb 23, 2019
@fingolfin fingolfin removed this from the GAP 4.10.1 milestone Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fingolfin fingolfin fingolfin approved these changes

Assignees

No one assigned

Labels

release notes: added PRs introducing changes that have since been mentioned in the release notes topic: build system topic: julia Julia GC integration and related matters

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sebasguts @coveralls @fingolfin @olexandr-konovalov