Skip to content

kernel: add 'static' keyword where possible #3204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fingolfin merged 2 commits into from
Jan 23, 2019
Merged

kernel: add 'static' keyword where possible #3204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
846d67b
kernel: add 'static' keyword where possible
fingolfin Jan 22, 2019
e8dee1e
kernel: run clang-format on previous commit
fingolfin Jan 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
272 changes: 68 additions & 204 deletions src/ariths.c
View file
Open in desktop

Large diffs are not rendered by default.

166 changes: 51 additions & 115 deletions src/blister.c
View file
Open in desktop

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions src/boehm_gc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ void InitFreeFuncBag(UInt type, TNumFreeFuncBags finalizer_func)

#ifndef WARD_ENABLED

void StandardFinalizer(void * bagContents, void * data)
static void StandardFinalizer(void * bagContents, void * data)
{
Bag bag;
void * bagContents2;
Expand Down Expand Up @@ -121,7 +121,7 @@ static unsigned GCMKind[MAX_GC_PREFIX_DESC + 1];
* the overhead is negligible for large objects.
*/

void BuildPrefixGCDescriptor(unsigned prefix_len)
static void BuildPrefixGCDescriptor(unsigned prefix_len)
{

if (prefix_len) {
Expand Down Expand Up @@ -195,7 +195,7 @@ static void TLAllocatorInit(void)
** references to other bags, and > 0 to indicate a specific memory layout
** descriptor.
**/
void * AllocateBagMemory(int gc_type, int type, UInt size)
static void * AllocateBagMemory(int gc_type, int type, UInt size)
{
assert(gc_type >= -1);
void * result = NULL;
Expand Down Expand Up @@ -239,7 +239,7 @@ void * AllocateMemoryBlock(UInt size)
return GC_malloc(size);
}

int TabMarkTypeBags[NUM_TYPES];
static int TabMarkTypeBags[NUM_TYPES];

void InitMarkFuncBags(UInt type, TNumMarkFuncBags mark_func)
{
Expand Down
71 changes: 18 additions & 53 deletions src/bool.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,9 @@ Obj Undefined;
**
** 'TypeBool' is the function in 'TypeObjFuncs' for boolean values.
*/
Obj TYPE_BOOL;
static Obj TYPE_BOOL;

Obj TypeBool (
Obj val )
static Obj TypeBool(Obj val)
{
return TYPE_BOOL;
}
Expand All @@ -86,8 +85,7 @@ Obj TypeBool (
**
** 'PrintBool' prints the boolean value <bool>.
*/
void PrintBool (
Obj bool )
static void PrintBool(Obj bool)
{
if ( bool == True ) {
Pr( "true", 0L, 0L );
Expand All @@ -111,9 +109,7 @@ void PrintBool (
** 'EqBool' returns '1' if the two boolean values <boolL> and <boolR> are
** equal, and '0' otherwise.
*/
Int EqBool (
Obj boolL,
Obj boolR )
static Int EqBool(Obj boolL, Obj boolR)
{
return boolL == boolR;
}
Expand All @@ -125,9 +121,7 @@ Int EqBool (
**
** The ordering of Booleans is true < false < fail.
*/
Int LtBool (
Obj boolL,
Obj boolR )
static Int LtBool(Obj boolL, Obj boolR)
{
if (boolL == True)
return boolR != True;
Expand All @@ -148,11 +142,9 @@ Int LtBool (
** 'IsBool' returns 'true' if <obj> is a boolean value and 'false'
** otherwise.
*/
Obj IsBoolFilt;
static Obj IsBoolFilt;

Obj IsBoolHandler (
Obj self,
Obj obj )
static Obj IsBoolHandler(Obj self, Obj obj)
{
/* return 'true' if <obj> is a boolean and 'false' otherwise */
if ( TNUM_OBJ(obj) == T_BOOL ) {
Expand All @@ -177,9 +169,7 @@ Obj IsBoolHandler (
** Those functions are useful for dispatcher tables if the types already
** determine the outcome.
*/
Obj ReturnTrue1 (
Obj self,
Obj val1 )
static Obj ReturnTrue1(Obj self, Obj val1)
{
return True;
}
Expand All @@ -189,10 +179,7 @@ Obj ReturnTrue1 (
**
*F ReturnTrue2( <val1>, <val2> ) . . . . . . . . . . . . . . return 'True'
*/
Obj ReturnTrue2 (
Obj self,
Obj val1,
Obj val2 )
static Obj ReturnTrue2(Obj self, Obj val1, Obj val2)
{
return True;
}
Expand All @@ -202,11 +189,7 @@ Obj ReturnTrue2 (
**
*F ReturnTrue3( <val1>, <val2>, <val3> ) . . . . . . . . . . return 'True'
*/
Obj ReturnTrue3 (
Obj self,
Obj val1,
Obj val2,
Obj val3 )
static Obj ReturnTrue3(Obj self, Obj val1, Obj val2, Obj val3)
{
return True;
}
Expand All @@ -218,9 +201,7 @@ Obj ReturnTrue3 (
**
** 'ReturnFalse?' likewise return 'False'.
*/
Obj ReturnFalse1 (
Obj self,
Obj val1 )
static Obj ReturnFalse1(Obj self, Obj val1)
{
return False;
}
Expand All @@ -230,10 +211,7 @@ Obj ReturnFalse1 (
**
*F ReturnFalse2( <val1>, <val2> ) . . . . . . . . . . . . . return 'False'
*/
Obj ReturnFalse2 (
Obj self,
Obj val1,
Obj val2 )
static Obj ReturnFalse2(Obj self, Obj val1, Obj val2)
{
return False;
}
Expand All @@ -243,11 +221,7 @@ Obj ReturnFalse2 (
**
*F ReturnFalse3( <val1>, <val2>, <val3> ) . . . . . . . . . return 'False'
*/
Obj ReturnFalse3 (
Obj self,
Obj val1,
Obj val2,
Obj val3 )
static Obj ReturnFalse3(Obj self, Obj val1, Obj val2, Obj val3)
{
return False;
}
Expand All @@ -259,9 +233,7 @@ Obj ReturnFalse3 (
**
** 'ReturnFail?' likewise return 'Fail'.
*/
Obj ReturnFail1 (
Obj self,
Obj val1 )
static Obj ReturnFail1(Obj self, Obj val1)
{
return Fail;
}
Expand All @@ -271,10 +243,7 @@ Obj ReturnFail1 (
**
*F ReturnFail2( <val1>, <val2> ) . . . . . . . . . . . . . . return 'Fail'
*/
Obj ReturnFail2 (
Obj self,
Obj val1,
Obj val2 )
static Obj ReturnFail2(Obj self, Obj val1, Obj val2)
{
return Fail;
}
Expand All @@ -284,11 +253,7 @@ Obj ReturnFail2 (
**
*F ReturnFail3( <val1>, <val2>, <val3> ) . . . . . . . . . . return 'Fail'
*/
Obj ReturnFail3 (
Obj self,
Obj val1,
Obj val2,
Obj val3 )
static Obj ReturnFail3(Obj self, Obj val1, Obj val2, Obj val3)
{
return Fail;
}
Expand All @@ -301,7 +266,7 @@ Obj ReturnFail3 (
** Actually, there is nothing to do
*/

void SaveBool( Obj obj )
static void SaveBool(Obj obj)
{
}

Expand All @@ -312,7 +277,7 @@ void SaveBool( Obj obj )
** Actually, there is nothing to do
*/

void LoadBool( Obj obj )
static void LoadBool(Obj obj)
{
}

Expand Down
Loading