kernel: remove 'extern' from function prototypes #3202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
topic: kernel
release notes: not needed
This was referenced Jan 20, 2019
Codecov Report
@@ Coverage Diff @@
## master #3202 +/- ##
=========================================
Coverage ? 84.77%
=========================================
Files ? 687
Lines ? 335864
Branches ? 0
=========================================
Hits ? 284723
Misses ? 51141
Partials ? 0
|
ChrisJefferson
approved these changes
Jan 21, 2019
Contributor
ChrisJefferson
left a comment
ChrisJefferson
left a comment
There was a problem hiding this comment.
I prefer this, but I don't know if anyone else has any opinions!
fingolfin
force-pushed
the
mh/no-extern
branch
3 times, most recently
from
28037a7 to
40a5067
Compare
... and also drop some inappropriate uses of 'extern'
fingolfin
force-pushed
the
mh/no-extern
branch
from
40a5067 to
e1cc1a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to PR #3183: instead of adding
externto function prototypes without it, this instead removesexternfrom all (?) function prototypes (and also in a few places in C files were it made no sense).The second commit was created by
git clang-format HEAD^to reformat all the modified function prototypes. The idea being that if we touch all those lines anyway, we might as well fix up their formatting at the same time. But of course if people dislike this, we can easily drop that second commit.Closes #3183