Replaced ReadTest by Test with comparison up to whitespaces.#290
Conversation
|
Ignore the last sentence - there is already |
|
I'm happy to see this merged -- it might well break some package's test but if it does the fixes will be very simple, so it seem like a good candidate for the 4.8 beta. |
|
@ChrisJefferson thanks. As I've said, I've run "make testpackages" and because the comparison is up to whitespaces, I don't think that any reported diffs were new - they were just reported in a better way. I am going to merge this then. |
Replaced ReadTest by Test with comparison up to whitespaces.
|
I've merged this. One extra reason for this is that now outputs of default tests in packages will be more uniform and it will be easy to detect whether they have diffs or not in automated scenarios and send failure notifications to package maintainers. |
|
P.S. Just discovered that (it's not documented what it returns). It happened that for a couple of packages using |
This implements the idea from issue #172 to make
ReadTestobsolete and replace it by a call totestwith comparison up to whitespaces. I've tested it on those packages which are still usingReadTestsand it works fine - the tests now produce the new output, and nothing is broken.Probably the kernel function
READ_TEST_OR_LOOPcould be also renamed toREAD_LOOP.