Update obsolete.gd #2781
Merged
Update obsolete.gd #2781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2781 +/- ##
==========================================
+ Coverage 68.1% 75.87% +7.77%
==========================================
Files 480 481 +1
Lines 241225 241310 +85
==========================================
+ Hits 164275 183099 +18824
+ Misses 76950 58211 -18739
|
olexandr-konovalov
approved these changes
Sep 6, 2018
Member
olexandr-konovalov
left a comment
olexandr-konovalov
left a comment
There was a problem hiding this comment.
In particular, DeclarePackage, DeclareAutoPackage, DeclarePackageAutoDocumentation, and DeclarePackageDocumentation are all now unused and I hence disabled them.
These are the only four that will be completely disabled by this PR. The rest of it only updates comments. Looks good, thanks.
Member
Author
|
I think we should mention this in the release notes, even though nobody will care... Agreed? |
fingolfin
added
the
release notes: to be added
fingolfin
added
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the list of obsoletes.
In particular,
DeclarePackage,DeclareAutoPackage,DeclarePackageAutoDocumentation, andDeclarePackageDocumentationare all now unused and I hence disabled them.Sadly we also had one regression:
Tupleis now used bynumericalsgpswhen it wasn't before.