Some filter related refactoring #2775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows removing the test for it being unset in RankFilter.
This optimization avoids creating a temporary list object
Also move `atomic FILTER_REGION` into OPER_SetupAttribute, and refactor NewProperty and NewCategory
fingolfin
added
topic: library
release notes: not needed
Codecov Report
@@ Coverage Diff @@
## master #2775 +/- ##
==========================================
- Coverage 75.87% 75.87% -0.01%
==========================================
Files 481 481
Lines 241310 241289 -21
==========================================
- Hits 183098 183076 -22
- Misses 58212 58213 +1
|
ChrisJefferson
approved these changes
Sep 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains two commits from PR #2773 (and thus part of PR #2521), plus some additional refactoring in related files.