Fix CanEasilyDetermineCanonicalRepresentativeExternalSet #2742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was declared as an attribute, but should be a property.
Due to a bug in GAP, we nevertheless accept expressions like
IsExternalOrbit and CanEasilyDetermineCanonicalRepresentativeExternalSet
e.g. when installing methods. But that does *not* do what one might expect in
method selection; rather, it is equivalent to
IsExternalOrbit and HasCanEasilyDetermineCanonicalRepresentativeExternalSet
as can be verified with this code (only *before* this commit)
gap> f1 := IsExternalOrbit and CanEasilyDetermineCanonicalRepresentativeExternalSet;;
gap> f2 := IsExternalOrbit and HasCanEasilyDetermineCanonicalRepresentativeExternalSet;;
gap> FLAGS_FILTER(f1) = FLAGS_FILTER(f2);
true
fingolfin
added
kind: bug
Codecov Report
@@ Coverage Diff @@
## master #2742 +/- ##
==========================================
+ Coverage 75.78% 75.78% +<.01%
==========================================
Files 478 478
Lines 241438 241438
==========================================
+ Hits 182973 182978 +5
+ Misses 58465 58460 -5
|
olexandr-konovalov
approved these changes
Aug 26, 2018
fingolfin
deleted the
mh/fix-CanEasilyDetermineCanonicalRepresentativeExternalSet
branch
fingolfin
added
the
release notes: not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was declared as an attribute, but should be a property.
Due to a bug in GAP, we nevertheless accept expressions like
e.g. when installing methods. But that does not do what one might expect in
method selection; rather, it is equivalent to
as can be verified with this code (only before this commit)
This is part of PR #2732, but should not be delayed by the rest of that PR.