Fix crash when tracing buggy attributes/properties; add a bunch of tests #2711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
kind: bug
Codecov Report
@@ Coverage Diff @@
## master #2711 +/- ##
==========================================
+ Coverage 75.66% 75.75% +0.09%
==========================================
Files 478 478
Lines 241441 241443 +2
==========================================
+ Hits 182678 182908 +230
+ Misses 58763 58535 -228
|
If an attribute or property returns nothing (resp. something other than true or false), this is an error, which we normally catch. But when tracing is enabled for the relevant operations, we would instead crash.
ChrisJefferson
approved these changes
Aug 19, 2018
Contributor
ChrisJefferson
left a comment
ChrisJefferson
left a comment
There was a problem hiding this comment.
That is some extensive testing :)
fingolfin
added
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.