Skip to content

Conversation

@fingolfin
Copy link
Member

With PR #2640 merged, I am submitting the remaining MatrixObj changes as separate PRs.

This one contains the TODO file we created, only mildly edited. I think there is no harm in just merging this as-is, as long as we don't forget that it's there, and keep updating it... Actually, I think it is already somewhat outdated...

An alternative would be to put this onto a Wiki page, with markdown to created checkboxes for every TODO item. I am neutral on this.

@fingolfin fingolfin added the release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes label Aug 15, 2018
@codecov
Copy link

codecov bot commented Aug 15, 2018

Codecov Report

Merging #2708 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2708      +/-   ##
==========================================
+ Coverage   75.65%   75.66%   +<.01%     
==========================================
  Files         478      478              
  Lines      241422   241421       -1     
==========================================
+ Hits       182658   182664       +6     
+ Misses      58764    58757       -7
Impacted Files Coverage Δ
src/stringobj.c 94.06% <0%> (+0.11%) ⬆️
src/objset.c 84.82% <0%> (+0.22%) ⬆️
hpcgap/lib/hpc/stdtasks.g 64.7% <0%> (+1.27%) ⬆️

Copy link
Contributor

@ThomasBreuer ThomasBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep this TODO list until it becomes obsolete.
(I am aware of the fact that I am expected to do part of the work.)

@fingolfin fingolfin merged commit bad7cf9 into gap-system:master Aug 17, 2018
@fingolfin fingolfin deleted the mh/MatrixObj-TODO branch August 17, 2018 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants