buildsys: simplify C compilation build rule #2704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
topic: build system
release notes: not needed
Instead of having two Makefile rules for C compilation, one for gen/*.c and one for src/*.c, use a single rule, by uniformly placing the object files for FOO/*.c into obj/FOO/*.c. As a side effect, it now becomes trivial to use the general build rule for C files in arbitrary locations, e.g. as part of the test suite.
fingolfin
force-pushed
the
mh/buildsys-simplify
branch
from
0e486ca to
da8f5e9
Compare
Codecov Report
@@ Coverage Diff @@
## master #2704 +/- ##
==========================================
+ Coverage 75.52% 75.52% +<.01%
==========================================
Files 478 478
Lines 241590 241620 +30
==========================================
+ Hits 182465 182493 +28
- Misses 59125 59127 +2
|
markuspf
approved these changes
Aug 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having two Makefile rules for C compilation, one for gen/.c and one for src/.c, use a single rule, by uniformly placing the object files for FOO/.c into obj/FOO/.c.
As a side effect, it now becomes trivial to use the general build rule for C
files in arbitrary locations, e.g. as part of the test suite.
This change comes from PR #2667, but it may be of independent use in PR #2702 for the C test file; and also for writing C based kernel tests, see issue #1917.