ProjectiveActionOnFullSpace: use list of vectors as domain #2641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... for an action, instead of a matrix
fingolfin
added
topic: library
release notes: not needed
Codecov Report
@@ Coverage Diff @@
## master #2641 +/- ##
==========================================
- Coverage 75.14% 75.14% -0.01%
==========================================
Files 478 478
Lines 242233 242232 -1
==========================================
- Hits 182028 182014 -14
- Misses 60205 60218 +13
|
sebasguts
approved these changes
Jul 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... for an action, instead of a matrix
This change is motivated by (and also part of) PR #2640 -- in general, a MatrixObj is not a list-of-row-vectors.
The code using the domain later on really only needs it as a list, as far as I could tell.