kernel: remove unused {8,16,32}Bits_Quotient #2615
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
topic: kernel
release notes: not needed
Codecov Report
@@ Coverage Diff @@
## master #2615 +/- ##
==========================================
+ Coverage 74.8% 74.83% +0.02%
==========================================
Files 479 479
Lines 242251 242803 +552
==========================================
+ Hits 181206 181690 +484
- Misses 61045 61113 +68
|
hulpke
approved these changes
Jul 4, 2018
Contributor
hulpke
left a comment
hulpke
left a comment
There was a problem hiding this comment.
I'm not sure why this was never included. Before removing the code as untested, it would be nice to have some comparison (even just a single experiment) on whether there would have been any impact.
Member
Author
|
@hulpke that's what the other PR does ... |
ThomasBreuer
reviewed
Jul 5, 2018
Contributor
ThomasBreuer
left a comment
ThomasBreuer
left a comment
There was a problem hiding this comment.
My preference would be the alternative #2616.
(I do not know why the kernel functions were never installed as methods.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #2616.
Resolves #2504. Closes #2616 .