Skip to content

kernel: don't show garbage if EOF aborts string parsing #2470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fingolfin merged 1 commit into from
May 17, 2018
Merged

kernel: don't show garbage if EOF aborts string parsing #2470

fingolfin merged 1 commit into from
May 17, 2018

Conversation

@fingolfin
Copy link
Member

@fingolfin fingolfin commented May 16, 2018

Fixes #2176

@fingolfin fingolfin added kind: bug Issues describing general bugs, and PRs fixing them topic: kernel labels May 16, 2018
@codecov
Copy link

codecov bot commented May 16, 2018 •
edited
Loading

Codecov Report

Merging #2470 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2470      +/-   ##
==========================================
+ Coverage   74.03%   74.03%   +<.01%     
==========================================
  Files         484      484              
  Lines      245282   245284       +2     
==========================================
+ Hits       181584   181588       +4     
+ Misses      63698    63696       -2
Impacted Files Coverage Δ
src/scanner.c 93.33% <100%> (+0.49%) ⬆️
hpcgap/lib/hpc/stdtasks.g 64.7% <0%> (-0.26%) ⬇️
src/hpc/threadapi.c 43.48% <0%> (-0.11%) ⬇️
lib/string.gi 48% <0%> (+0.12%) ⬆️
src/stats.c 87.19% <0%> (+0.13%) ⬆️

@fingolfin fingolfin merged commit 9aa29a7 into gap-system:master May 17, 2018
@fingolfin fingolfin deleted the mh/fix-string-eof-garbage branch May 17, 2018 11:09
@fingolfin fingolfin added the release notes: added PRs introducing changes that have since been mentioned in the release notes label Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevelinton stevelinton stevelinton approved these changes

@ChrisJefferson ChrisJefferson Awaiting requested review from ChrisJefferson

Assignees

No one assigned

Labels

kind: bug Issues describing general bugs, and PRs fixing them release notes: added PRs introducing changes that have since been mentioned in the release notes topic: kernel

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fingolfin @stevelinton