Remove hack that disabled 64-bit builds of digraphs and float #2391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I don't know what helped to this, but now both Float and Digraphs are both buildable and loadable (CC @james-d-mitchell and @laurentbartholdi) |
fingolfin
approved these changes
Apr 23, 2018
Member
fingolfin
left a comment
fingolfin
left a comment
There was a problem hiding this comment.
Perhaps something in the Travis build process changed?
fingolfin
added
topic: tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #2119 added Travis test of loading packages, but disabled building Digraphs and Float because they can be compiled, but their loading failed with an "undefined symbol: atexit" error.
This PR removes that hack in order to check if the problem persists and act accordingly.