Skip to content

Fix sparse pperm #2305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fingolfin merged 9 commits into from
Apr 6, 2018
Merged

Fix sparse pperm #2305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
32b4ca4
Fix bug in PartialPerm if length of img and dom differ
Mar 26, 2018
4bdb4e4
pperm: remove randomness from tests
Mar 26, 2018
c60d83c
pperm: IsPosInt -> IsPosInt and IsSmallIntRep
Mar 26, 2018
66fe347
pperm: add tests and resolve issues in GAP code
Mar 27, 2018
a510753
pperm: add assertions to kernel functions
Mar 26, 2018
fb13e86
pperm: add tests and resolve issues in C code
Mar 27, 2018
4e425fa
pperm: GAP code formatted
Mar 29, 2018
37aee87
pperm: kernel code formatted
Mar 29, 2018
aedc32e
pperm: fix bug in PreImagePPermInt
Apr 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions lib/pperm.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,13 @@
##############################################################################
###


DeclareUserPreference(rec(
name:=["PartialPermDisplayLimit", "NotationForPartialPerms"],
description:=["options for the display of partial perms"],
default:=[100, "component"],
check:=function(a, b)
return IsPosInt(a)
or (IsString(b) and b in ["component", "domainimage", "input"]);
name := ["PartialPermDisplayLimit", "NotationForPartialPerms"],
description := ["options for the display of partial perms"],
default := [100, "component"],
check := function(a, b)
return IsPosInt(a)
or (IsString(b) and b in ["component", "domainimage", "input"]);
end));

DeclareGlobalFunction("ComponentStringOfPartialPerm");
Expand Down Expand Up @@ -52,7 +51,7 @@ DeclareAttribute("SmallestImageOfMovedPoint", IsPartialPerm);
DeclareAttribute("SmallestImageOfMovedPoint", IsPartialPermCollection);

# operations
DeclareOperation("PreImagePartialPerm",[IsPartialPerm, IsPosInt]);
DeclareOperation("PreImagePartialPerm", [IsPartialPerm, IsPosInt]);
DeclareOperation("ComponentPartialPermInt", [IsPartialPerm, IsPosInt]);
DeclareOperation("AsPartialPerm", [IsAssociativeElement, IsList]);
DeclareOperation("AsPartialPerm", [IsAssociativeElement]);
Expand Down
Loading