Refactor and fix DeclareAttribute
#2078
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the result of trying to fix a bug in DeclareAttribute where if the user called it with the same name but different filters, the attributes would be setup correctly, but the second would not be added to the list ATTRIBUTES. The argument parsing made it impossible to give "mutable" and a rank for the attribute: If one gave "mutable", the rank would be ignored.
If a user called `DeclareAttribute` more than once with the same attribute
name, but with different filters:
```
gap> DeclareAttribute("PlaceHolder", IsGroup);
gap> DeclareAttribute("PlaceHolder", IsMultiplicativeElement);
```
the attributes would be created correctly, but the second instance was
not registered in the global list ATTRIBUTES. This commit fixes this.
Member
Author
|
Currently there is neither updated documentation nor are there tests. |
fingolfin
requested changes
Jan 10, 2018
Member
fingolfin
left a comment
fingolfin
left a comment
There was a problem hiding this comment.
This PR modifies lib/oper.g but does not sync the changes with hpcgap/lib/oper.g, which needs to be done before merging it (but of course it can be postponed until the rest of the PR has been reviewed positively)
markuspf
force-pushed
the
oper-attr-fix
branch
from
f0c5b2a to
ee4cdd2
Compare
Member
Author
|
I discovered that, to fix this issue properly, I will have to do more things, so I will submit smaller PRs that do the refactoring and the fixes I believe are correct separately. |
This was referenced Jan 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a result of trying to fix a bug in
DeclareAttribute, namely if a user did the followingThen the second instance of
PlaceHolderwould not be stored in the global arrayATTRIBUTES.In the process this PR also fixes a bug with argument parsing in
DeclareAttributeandNewAttribute, where if one gave"mutable"as third argument, the argument for rank would be ignored.We now allow passing
trueorfalseas well as the string "mutable" as mutability flag.