kernel cleanup: add NUM_TYPES and T_DUMMY #1700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
do not merge
Codecov Report
@@ Coverage Diff @@
## master #1700 +/- ##
==========================================
+ Coverage 75.34% 75.34% +<.01%
==========================================
Files 442 442
Lines 228957 228958 +1
==========================================
+ Hits 172498 172499 +1
Misses 56459 56459
|
olexandr-konovalov
added
the
gapdays2017-fall
fingolfin
force-pushed
the
mh/NUM_TYPES
branch
from
047220a to
cc8e638
Compare
23 tasks
fingolfin
changed the title
fingolfin
added
release notes: not needed
Member
Author
|
Reminder: should this get merged, rebase PR #2092 (Julia GC) on it, and edit |
ChrisJefferson
approved these changes
Jul 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, we reserve 8 bit for the tnum in each "Bag". GASMAN also uses the special value
255 = 0xFFin the tnum/type field internally, so that means TNUMs from 0 to 254 are potentially valid.Now there are various places were this information is implicitly used. If we ever want to e.g. increase the number of TNUMs, we have to find all these places. And even if we don't change it, it can be illuminating to have these facts made explicit. This PR is a first step at doing that.