Skip to content

Require setup-gap@v3 to simplify some code #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fingolfin wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −22
Open

Require setup-gap@v3 to simplify some code #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,7 @@ jobs:
uses: actions/checkout@v6
with:
path: this-action/
- uses: gap-actions/setup-gap@v2
with:
GAP_PKGS_TO_BUILD: ''
- uses: gap-actions/setup-gap@v3
- uses: gap-actions/build-pkg@v2
- uses: ./this-action/
with:
Expand Down Expand Up @@ -128,9 +126,7 @@ jobs:
uses: actions/checkout@v6
with:
path: this-action/
- uses: gap-actions/setup-gap@v2
with:
GAP_PKGS_TO_BUILD: ''
- uses: gap-actions/setup-gap@v3
- uses: gap-actions/build-pkg@v2
- uses: ./this-action/
with:
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ All of the following inputs are optional.
### What's new in v4

There are several changes between v3 and v4: the introduction of the `mode` option,
the renaming of some options,
the renaming of some options, the requirement for using `gap-actions/setup-gap@v3` or newer
Copy link
Member Author

@fingolfin fingolfin Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've rebased this PR now; but since we already released v4, I feel this should really be waiting for a v5 release.

It's not urgent right now: before worrying about this PR at all, we should get at least all gap-packages repos to use setup-gap@v3 in their CI.yml. Right now just 9 out of 150 do that :-/.

Copy link
Member

@limakzi limakzi Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fingolfin Shall we help them and make pull-requests? Haha!

and the restriction of the allowed values for boolean-like options.

#### Renamed options
Expand Down
16 changes: 1 addition & 15 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,20 +53,6 @@ runs:
run: |
set -ex

GAPROOT=${GAPROOT-$HOME/gap}

# set up a custom GAP root containing only this package, so that
# we can force GAP to load the correct version of this package
# (we already did that in build_pkg.sh, but we do it again here,
# to allow the occasional instance where a package wants to also
# run the tests of others packages, by invoking this script multiple
# times in different directories)
mkdir -p /tmp/gaproot/pkg/
ln -f -s $PWD /tmp/gaproot/pkg/

# start GAP with custom GAP root, to ensure correct package version is loaded
GAP="$GAPROOT/gap -l /tmp/gaproot; --quitonbreak"

# Prepend pre-gap prefix, if it exists
if [[ ! -z "${{ inputs.pre-gap }}" ]]; then
GAP="${{ inputs.pre-gap }} $GAP"
Expand Down Expand Up @@ -96,7 +82,7 @@ runs:
fi;

SetInfoLevel(InfoPackageLoading, PACKAGE_DEBUG);
SetPackagePath(info.PackageName, "/tmp/gaproot/pkg/$(basename $PWD)");
SetPackagePath(info.PackageName, "$PWD");

# Capture the output of loading
output := "";
Expand Down
Loading