Benchmark Layer Skip #1
Conversation
|
I ran for a large number of models, comparing 2-model speculative decoding and self-speculative decoding and put the results here (note there is a separate sheet for each task): Cc @gante |
|
Perfect, thank you for opening the PR 💛 I'll merge this one as soon as the |
|
|
||
| if args.max_gpu_memory is None: # fails if it doesn't fit in a GPU | ||
| max_memory = {0: "100GiB", "cpu": "0GiB"} | ||
| max_memory = {0: "100GiB", "cpu": "50GiB"} |
There was a problem hiding this comment.
n00b question: why do we need to modify max_memory?
For Llama2 70B ran on 8 A100 GPUs, I had to replace this line with:
max_memory = None
to get it to work
There was a problem hiding this comment.
haha for no good reason: long ago, when I wrote this script, my setup crashed if a) the model didn't fully fit on the GPU OR b) I didn't set a limit slightly below the device capacity -- e.g. 20GiB on a RTX3090 (24GB)
can and should be replaced
There was a problem hiding this comment.
Haha ... OK. I submitted a commit to keep max memory to None if it is not specified by the user
|
After merging huggingface/transformers#34240 I think this PR is ready to merge. |
|
Just noticed there are conflicts. Working now on resolving them. |
mostafaelhoushi
force-pushed
the
layer-skip
branch
from
7b320bc to
adaa02c
Compare
|
I re-ran commands to verify that they are working and fixed some further errors that popped up. |
|
Hi @gante . Just a gentle ping if you would like to merge the PR |
|
this pr is helpful, since there is no official huggingfaces' version of layerskip benchmark, pls merge it |
3 participants
I followed this blog and implemented early exit self-speculation here.