feat(orchestrator): build reliability features — git integrity, reserved filenames, archival#808
Closed
frostebite wants to merge 6 commits intomainfrom
Closed
feat(orchestrator): build reliability features — git integrity, reserved filenames, archival#808frostebite wants to merge 6 commits intomainfrom
frostebite wants to merge 6 commits intomainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three optional reliability features that harden the build pipeline for self-hosted runners and enterprise environments (#807).
Features
gitIntegrityCheckfalsegit fsck, stale lock cleanup, submodule backing store validationgitAutoRecovertruecleanReservedFilenamesfalsebuildArchiveEnabledfalsebuildArchivePath''buildArchiveRetention3New Service
BuildReliabilityServiceatsrc/model/orchestrator/services/reliability/with methods:cleanStaleLockFiles()— Remove stale git lock files from.git/cleanReservedFilenames()— Scan and remove Windows reserved device names from Assets/validateSubmoduleBackingStores()— Verify submodule.gitfiles point to existing backing storesenforceRetention()— Post-build archival with configurable retention countconfigureGitEnvironment()— Set CI-friendly git environment variables (GIT_CONFIG_NOSYSTEM=1)All features are opt-in and fail gracefully (warnings only, never blocks the build).
Test coverage
5 unit tests covering:
.gitdirectory).gitmodules)Related
Test plan
gitIntegrityCheck: trueon a self-hosted runnercleanReservedFilenames: trueon a project with reserved namesbuildArchiveEnabled: trueto verify retention policySummary by CodeRabbit
New Features
Tests
Chores
Tracking: