-
-
Notifications
You must be signed in to change notification settings - Fork 307
feat(orchestrator): incremental sync protocol — git delta, direct input, and storage-backed sync #799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(orchestrator): incremental sync protocol — git delta, direct input, and storage-backed sync #799
Changes from all commits
3033ee0
4870fb5
07eec62
d503b0b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -241,6 +241,28 @@ class Input { | |||||||||||||||||||||
| return Input.getInput('dockerWorkspacePath') ?? '/github/workspace'; | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| static get syncStrategy(): string { | ||||||||||||||||||||||
| return Input.getInput('syncStrategy') ?? 'full'; | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| static get syncInputRef(): string { | ||||||||||||||||||||||
| return Input.getInput('syncInputRef') ?? ''; | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| static get syncStorageRemote(): string { | ||||||||||||||||||||||
| return Input.getInput('syncStorageRemote') ?? ''; | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| static get syncRevertAfter(): boolean { | ||||||||||||||||||||||
| const input = Input.getInput('syncRevertAfter') ?? 'true'; | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| return input === 'true'; | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
|
Comment on lines
+256
to
+260
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Parse Values like Proposed fix static get syncRevertAfter(): boolean {
const input = Input.getInput('syncRevertAfter') ?? 'true';
- return input === 'true';
+ return input.toLowerCase() === 'true';
}📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||
|
|
||||||||||||||||||||||
| static get syncStatePath(): string { | ||||||||||||||||||||||
| return Input.getInput('syncStatePath') ?? '.game-ci/sync-state.json'; | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| static get dockerCpuLimit(): string { | ||||||||||||||||||||||
| return Input.getInput('dockerCpuLimit') ?? os.cpus().length.toString(); | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: game-ci/unity-builder
Length of output: 3713
🏁 Script executed:
cat -n .github/workflows/build-tests-ubuntu.yml | head -200Repository: game-ci/unity-builder
Length of output: 10434
🏁 Script executed:
sed -n '200,220p' .github/workflows/build-tests-ubuntu.ymlRepository: game-ci/unity-builder
Length of output: 467
Move
continue-on-errorto step level and guard the upload step.At Line 15, job-level
continue-on-error: trueallows the workflow run to pass even when a matrix leg fails. It also does not make the later upload step run after a failed build, because steps still default toif: success()unless explicitly overridden. Movecontinue-on-errorto the build step and give the upload step an explicit condition so artifacts are still collected on failure.Suggested change
buildForAllPlatformsMacOS: name: ${{ matrix.targetPlatform }} on ${{ matrix.unityVersion }} runs-on: macos-latest - continue-on-error: true strategy: fail-fast: false @@ - uses: ./ + continue-on-error: true env: UNITY_EMAIL: ${{ secrets.UNITY_EMAIL }} UNITY_PASSWORD: ${{ secrets.UNITY_PASSWORD }} UNITY_SERIAL: ${{ secrets.UNITY_SERIAL }} UNITY_LICENSE: ${{ secrets.UNITY_LICENSE }} @@ - uses: actions/upload-artifact@v4 + if: ${{ !cancelled() }} with: name: Build ${{ matrix.targetPlatform }} on MacOS (${{ matrix.unityVersion }})${{ matrix.buildProfile && ' With Build Profile' || '' }} path: build retention-days: 14🤖 Prompt for AI Agents