-
-
Notifications
You must be signed in to change notification settings - Fork 307
feat(orchestrator): generic artifact system — output types, manifests, and collection service #798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b3e1639
feat(orchestrator): generic artifact system — output types, manifests…
frostebite aa2e05d
feat(artifacts): complete generic artifact system with upload handler…
frostebite 7615bbd
fix(artifacts): validate rclone availability before storage upload
frostebite 1e2bb88
style: fix prettier formatting
frostebite ae03bd2
ci: set macOS builds to continue-on-error
frostebite 55b45a4
fix: replace orchestrator-develop branch references with main
frostebite File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: game-ci/unity-builder
Length of output: 1057
🏁 Script executed:
Repository: game-ci/unity-builder
Length of output: 1858
🏁 Script executed:
Repository: game-ci/unity-builder
Length of output: 1818
🏁 Script executed:
Repository: game-ci/unity-builder
Length of output: 2765
Remove job-level
continue-on-errorand implement step-level retries with delays like Ubuntu/Windows.Line 15 masks failing
buildForAllPlatformsMacOSmatrix runs without retrying, whilefail-fast: falseat line 17 only prevents matrix-wide cancellation. Ubuntu and Windows workflows implement explicit retry logic with step duplication and variable sleep delays (60–120s); macOS should follow the same pattern with acontinue-on-erroron the build step and conditional retry steps, not blanket job-level failure masking.Suggested removal
- continue-on-error: trueThen add step-level
continue-on-errorand explicit retry steps similar to Ubuntu/Windows.🤖 Prompt for AI Agents