Skip to content

feat(orchestrator): test workflow engine — suite definitions, taxonomy filters, structured results #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
frostebite wants to merge 5 commits into from
Closed

feat(orchestrator): test workflow engine — suite definitions, taxonomy filters, structured results #790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8d81236
feat(orchestrator): add test workflow engine placeholder
frostebite Mar 5, 2026
1186717
feat(testing): implement test workflow engine with YAML suites, taxon…
frostebite Mar 5, 2026
5e54bcd
fix(testing): use async exec for parallel test group execution
frostebite Mar 5, 2026
70a78da
ci: set macOS builds to continue-on-error
frostebite Mar 5, 2026
c5355c5
fix: replace orchestrator-develop branch references with main
frostebite Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/build-tests-mac.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ jobs:
buildForAllPlatformsMacOS:
name: ${{ matrix.targetPlatform }} on ${{ matrix.unityVersion }}
runs-on: macos-latest
continue-on-error: true
strategy:
fail-fast: false
matrix:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/orchestrator-async-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
# AWS_STACK_NAME: game-ci-github-pipelines
CHECKS_UPDATE: ${{ github.event.inputs.checksObject }}
run: |
git clone -b orchestrator-develop https://github.com/game-ci/unity-builder
git clone -b main https://github.com/game-ci/unity-builder
Copy link

@coderabbitai coderabbitai bot Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Clone the dispatched ref instead of always bootstrapping from main.

Line 57 now forces checks-update to run from the default-branch code even when this workflow is dispatched from a feature branch. That makes async checks validate the wrong revision and can hide regressions in the branch under review.

Suggested fix 
-          git clone -b main https://github.com/game-ci/unity-builder
+          BRANCH="${ORCHESTRATOR_BRANCH#refs/heads/}"
+          git clone -b "$BRANCH" https://github.com/game-ci/unity-builder \
+            || git clone -b main https://github.com/game-ci/unity-builder
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
git clone -b main https://github.com/game-ci/unity-builder
BRANCH="${ORCHESTRATOR_BRANCH#refs/heads/}"
git clone -b "$BRANCH" https://github.com/game-ci/unity-builder \
|| git clone -b main https://github.com/game-ci/unity-builder
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/orchestrator-async-checks.yml at line 57, Replace the
hardcoded "git clone -b main ..." invocation so the workflow checks out the
dispatched branch/commit instead of always bootstrapping from main;
specifically, stop using the literal "git clone -b main" and either use
actions/checkout@v4 with ref: ${{ github.ref }} (or ref: ${{ github.sha }}) or
adjust the git clone to use the dispatched ref variable (github.ref or
github.sha) so the workflow validates the exact revision of the dispatch.

cd unity-builder
yarn
ls
Expand Down
21 changes: 19 additions & 2 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,8 +182,8 @@ inputs:
required: false
default: ''
description:
'[Orchestrator] Run a custom job instead of the standard build automation for orchestrator (in yaml format with the
keys image, secrets (name, value object array), command line string)'
'[Orchestrator] Run a custom job instead of the standard build automation for orchestrator (in yaml format with
the keys image, secrets (name, value object array), command line string)'
awsStackName:
default: 'game-ci'
required: false
Expand Down Expand Up @@ -279,6 +279,23 @@ inputs:
description:
'[Orchestrator] Specifies the repo for the unity builder. Useful if you forked the repo for testing, features, or
fixes.'
testSuitePath:
description: 'Path to YAML test suite definition file'
required: false
testSuiteEvent:
description: 'CI event name for suite selection (pr, push, release)'
required: false
testTaxonomyPath:
description: 'Path to custom taxonomy definition YAML'
required: false
testResultFormat:
description: 'Test result output format: junit, json, or both'
required: false
default: 'junit'
testResultPath:
description: 'Directory for structured test result output'
required: false
default: './test-results'

outputs:
volume:
Expand Down
Loading
Loading