Skip to content

Build subtarget support for Unity 2021.2+#532

Merged
davidmfinol merged 2 commits intogame-ci:mainfrom
SunLionGames:build-subtarget
Apr 15, 2023
Merged

Build subtarget support for Unity 2021.2+#532
davidmfinol merged 2 commits intogame-ci:mainfrom
SunLionGames:build-subtarget

Conversation

@danielchipman
Copy link
Contributor

@danielchipman danielchipman commented Apr 15, 2023

Changes

  • Added support for -standaloneBuildSubtarget parameter via customParameters in order to facilitate dedicated server builds. Since Unity introduced the subtarget option in 2021.2, this parameter only takes effect in supported Unity versions.

Documentation PR: game-ci/documentation#389
Discussion: game-ci/documentation#240

Checklist

  • Read the contribution guide and accept the
    code of conduct
  • Docs (If new inputs or outputs have been added or changes to behavior that should be documented. Please make
    a PR in the documentation repo)
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

Allows passing the -standaloneBuildSubtarget parameter via customParameters in order to facilitate dedicated server builds. Since Unity introduced the subtarget option in 2021.2, this parameter only takes effect in supported Unity versions.
@github-actions
Copy link

Cat Gif

@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2023

Codecov Report

Merging #532 (77a98c4) into main (3032a4a) will not change coverage.
The diff coverage is n/a.

❗ Current head 77a98c4 differs from pull request most recent head bfc6ff3. Consider uploading reports for the commit bfc6ff3 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@           Coverage Diff            @@
##             main     #532    +/-   ##
========================================
  Coverage   36.97%   36.97%            
========================================
  Files          77       77            
  Lines        3032     3032            
  Branches      586      613    +27     
========================================
  Hits         1121     1121            
+ Misses       1908     1758   -150     
- Partials        3      153   +150     

see 38 files with indirect coverage changes

Copy link
Member

@davidmfinol davidmfinol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Certain versions of Unity do not have a value for `NoSubtarget`. Using `default` will be more robust against churn in this area of Unity's API.
@danielchipman
Copy link
Contributor Author

Apologies, did not realize I could run these tests locally on my fork before opening the PR. Seems this API unsurprisingly has gone through some churn and the fallback value I was using isn't available on all editor versions. Swapped it to default (which will resolve to Client) to guarantee compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants