Unity license activation on windows for test-runner and builder #28
Description
Bug description
I'm currently using game-ci/unity-builder and game-ci/unity-test-runner to build and test a Unity 2021.3.9f1 project.
I've setup two jobs for this:
test: https://github.com/BoundfoxStudios/community-project/blob/develop/.github/workflows/build.yml#L46build: https://github.com/BoundfoxStudios/community-project/blob/develop/.github/workflows/build.yml#L111
As you can see in the workflow definition, both jobs run on Linux, Windows and - for build only - macOS.
Building works reliably on all three operating systems any time.
Testing however has some issues. It works on Linux, but on windows it silently fails (see game-ci/unity-builder#325) due to a license activation error:
LICENSE SYSTEM [2022920 4:19:25] Machine binding 1 mismatch: (value of current machine) 00430-00000-00000-AA128 != 576562626572264761624c65526f7578 (value in license file). Reason might be there is a hardware change on this machine after the license was activated
I've noticed that all windows runs (tests and build) use the exact same image:
Digest: sha256:365aa88c7335177e5d7b5e4c911a9dae0b58c0092ef622c057c79e78e6512567
Status: Downloaded newer image for unityci/editor:windows-2021.3.9f1-windows-il2cpp-1
@GabLeRoux pointed out two scripts that are currently used for license activation:
test-runner: https://github.com/game-ci/unity-test-runner/blob/main/dist/steps/activate.ps1builder: https://github.com/game-ci/unity-builder/blob/main/dist/platforms/windows/activate.ps1
He also pointed out, that the ubuntu base images use a hardcoded machine id (https://github.com/game-ci/docker/blob/main/images/ubuntu/base/Dockerfile#L68) whereas the windows machine do not (https://github.com/game-ci/docker/blob/main/images/windows/base/Dockerfile).
@webbertakken pointed out that windows should take the serial out of the license file and activate it (not being sure if that is affected by the machine id):
For me, it seems that due to a difference in activating the license for test-runner and builder on windows, it can fail on the test-runner. I've never had a successful run so far. :)
I've also seen that any test-runner run fails activating with the same wrong machine id, it's always 00430-00000-00000-AA128.
Expected behavior
Test-Runner and Builder works on all operating systems.