Skip to content

Conversation

@guerler
Copy link
Contributor

@guerler guerler commented Dec 3, 2025

Removes unused and invalid javascript fragments embedded in the legacy toolshed makos that remain only as test fixtures. The runtime toolshed interface no longer references these templates due to the migration to the modern client, and the javascript blocks no longer match any active initialization path. This change strips the dead sections while preserving the minimal structure required for the tests that still load these files. The goal is to improve clarity in preparation for future toolshed work.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler added this to the 26.0 milestone Dec 3, 2025
@guerler guerler added kind/refactoring cleanup or refactoring of existing code, no functional changes area/testing area/toolshed labels Dec 3, 2025
@guerler guerler force-pushed the remove_unused_js_from_toolshed_makos branch 2 times, most recently from 8d9e3c5 to 45dbbf8 Compare December 4, 2025 17:52
@guerler guerler added minor and removed minor labels Dec 4, 2025
@guerler guerler force-pushed the remove_unused_js_from_toolshed_makos branch 9 times, most recently from c7062f8 to 15578b1 Compare December 9, 2025 16:13
@guerler guerler force-pushed the remove_unused_js_from_toolshed_makos branch 2 times, most recently from a844014 to 949c977 Compare December 10, 2025 09:45
@guerler guerler marked this pull request as ready for review December 10, 2025 13:06
@guerler guerler requested a review from itisAliRH December 11, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/testing area/toolshed kind/refactoring cleanup or refactoring of existing code, no functional changes minor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant