fix: make xcm config be consistent with system parachains#978
Closed
yrong wants to merge 3 commits intogalacticcouncil:masterfrom
Closed
fix: make xcm config be consistent with system parachains#978yrong wants to merge 3 commits intogalacticcouncil:masterfrom
yrong wants to merge 3 commits intogalacticcouncil:masterfrom
Conversation
yrong
changed the title
yrong
changed the title
yrong
changed the title
Author
|
Closed in favor of #961 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Always use
TrailingSetTopicAsIdto be consistent with system Parachains.Motivation and Context
Respect the topic ID of the xcm and Make indexing it across multiple chains a bit easier.
Transfer from Hydradx to Ethereum
https://hydration.subscan.io/block/6335192?tab=event&event=6335192-12
https://assethub-polkadot.subscan.io/block/7488254?tab=event&event=7488254-10
https://bridgehub-polkadot.subscan.io/block/3803578?tab=event&event=3803578-10
https://etherscan.io/tx/0x8a5314e1f222eedf660f68cf0c50012f45f6460dad044218c295be01a64f6c14#eventlog#511
Transfer from Ethereum to Hydradx
https://etherscan.io/tx/0xc242472754e5dbce0b88c33213084dd806f50c9e70b811879e8f2989798106e0#eventlog#245
https://bridgehub-polkadot.subscan.io/block/3732590?tab=event&event=3732590-7
https://assethub-polkadot.subscan.io/block/7417022?tab=event&event=7417022-10
https://hydration.subscan.io/block/6273113?tab=event&event=6273113-6