Skip to content

fix: benchmarking test for dispenser pallet #1376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
iamyxsh wants to merge 2 commits into from
Closed

fix: benchmarking test for dispenser pallet #1376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f14ac45
fixed benchmarking test for dispenser pallet
iamyxsh Mar 3, 2026
d6936e6
fixed version check and benchmarking file permission
iamyxsh Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pallets/dispenser/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "pallet-dispenser"
version = "0.2.0"
version = "0.2.1"
edition = "2021"

[package.metadata.docs.rs]
Expand Down
34 changes: 15 additions & 19 deletions pallets/dispenser/src/benchmarking.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,10 @@ mod benches {
#[benchmark]
fn set_faucet_balance() {
DispenserConfig::<T>::put(DispenserConfigData { paused: false });
let old = FaucetBalanceWei::<T>::get();
#[extrinsic_call]
set_faucet_balance(RawOrigin::Root, 123u128);
assert_eq!(FaucetBalanceWei::<T>::get(), 123u128);
assert_eq!(FaucetBalanceWei::<T>::get(), old + 123u128);
}

#[benchmark]
Expand Down Expand Up @@ -59,26 +60,21 @@ mod benches {
let fee_asset = T::FeeAsset::get();
let faucet_asset = T::FaucetAsset::get();

<T as pallet::Config>::Currency::set_balance(fee_asset, &signet_admin, 340266920938463463374607431768211455);
<T as pallet::Config>::Currency::set_balance(
faucet_asset,
&signet_admin,
340282366920938463463374607431768211455,
);
<T as pallet::Config>::Currency::set_balance(fee_asset, &pallet_account, 340266920938463463374607431768211455);
<T as pallet::Config>::Currency::set_balance(
faucet_asset,
&pallet_account,
340282366920938463463374607431768211455,
);
let large_balance: u128 = 1_000_000_000_000_000_000_000;
<T as pallet::Config>::Currency::set_balance(fee_asset, &signet_admin, large_balance);
<T as pallet::Config>::Currency::set_balance(faucet_asset, &signet_admin, large_balance);
<T as pallet::Config>::Currency::set_balance(fee_asset, &pallet_account, large_balance);
<T as pallet::Config>::Currency::set_balance(faucet_asset, &pallet_account, large_balance);

let ed_native: BalanceOf<T> = <T as pallet_signet::Config>::Currency::minimum_balance();
assert_ok!(pallet_signet::Pallet::<T>::initialize(
RawOrigin::Root.into(),
signet_admin,
ed_native,
chain_id,
));
if pallet_signet::Admin::<T>::get().is_none() {
assert_ok!(pallet_signet::Pallet::<T>::initialize(
RawOrigin::Root.into(),
signet_admin,
ed_native,
chain_id,
));
}

let requester_needed: BalanceOf<T> = ed_native.add(ed_native.mul(10u32.into()));
let _ = <T as pallet_signet::Config>::Currency::deposit_creating(&pallet_account, requester_needed);
Expand Down
4 changes: 2 additions & 2 deletions scripts/benchmarking.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ if [[ "${ALL}" -eq 1 ]]; then
for option in "${options[@]}"; do
_path="${OUTPUT}${option}.rs"

touch "${_path}" # TODO: Remove this once benchmarking-cli doesn't fail on missing files
chmod u+w "${_path}" 2>/dev/null; touch "${_path}" # TODO: Remove this once benchmarking-cli doesn't fail on missing files
bench "${option}" '*' "${CHECK}" "${_path}"
done
elif [[ "${ARGS[0]}" == *","* ]]; then
Expand All @@ -162,7 +162,7 @@ elif [[ "${ARGS[0]}" == *","* ]]; then
for _pallet in "${_pallets[@]}"; do
_pallet_trimmed="$(echo "${_pallet}" | xargs)"
_path="${OUTPUT}${_pallet_trimmed}.rs"
touch "${_path}" # TODO: Remove this once benchmarking-cli doesn't fail on missing files
chmod u+w "${_path}" 2>/dev/null; touch "${_path}" # TODO: Remove this once benchmarking-cli doesn't fail on missing files
bench "${_pallet_trimmed}" '*' "${CHECK}" "${_path}"
done
elif [[ ${#ARGS[@]} -ne 2 && ${#ARGS[@]} -ne 3 ]]; then
Expand Down
Loading