Add only logging.NullHandler to default_logger#704
Open
bsolomon1124 wants to merge 1 commit intofxsjy:masterfrom
bsolomon1124:nullhandler
Open
Add only logging.NullHandler to default_logger#704bsolomon1124 wants to merge 1 commit intofxsjy:masterfrom bsolomon1124:nullhandler
bsolomon1124 wants to merge 1 commit intofxsjy:masterfrom
bsolomon1124:nullhandler
Conversation
This is a library, not an application, and it should be up to the end user, not the developer, what the log level and handler is. Setting up the logger with a DEBUG level and sys.stderr handler is not a widely used practice in Python libraries. The common practice is to add only NullHandler: > An instance of this handler could be added to the top-level > logger of the logging namespace used by the library > (if you want to prevent your library’s logged events > being output to sys.stderr in the absence of logging configuration). See also: https://docs.python-guide.org/writing/logging/#logging-in-a-library
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a library, not an application, and it should be up to the end user, not the developer, what the log level and handler is.
Setting up the logger with a DEBUG level and sys.stderr handler is not a widely used practice in Python libraries. The common practice is to add only NullHandler:
See also:
https://docs.python-guide.org/writing/logging/#logging-in-a-library