Support for Swift 4.2.1 / Xcode 10.1#1
Merged
mkj-is merged 15 commits intofuturedapp:masterfrom Jan 21, 2019
RomanPodymov:swift_4.2
Merged
Support for Swift 4.2.1 / Xcode 10.1#1mkj-is merged 15 commits intofuturedapp:masterfrom RomanPodymov:swift_4.2
mkj-is merged 15 commits intofuturedapp:masterfrom
RomanPodymov:swift_4.2
Conversation
Contributor
|
Sorry we did not make the review sooner, but you forgot to add anyone to reviewers. |
mkj-is
reviewed
Jan 14, 2019
| } | ||
|
|
||
| func applicationWillResignActive(application: UIApplication) { | ||
| func applicationWillResignActive(_ application: UIApplication) { |
Contributor
There was a problem hiding this comment.
The same as in your LocationManager PR, feel free to delete these generated methods.
Contributor
Author
@mkj-is I don't have such permissions, but I hope that I will receive them soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good evening.
Thank you for this library, it is very interesting.
I added support of Swift 4.2.1 / Xcode 10.1. I fixed some warnings. Tested the example on a device with iOS 12.1.1 and it looks good.