-
Notifications
You must be signed in to change notification settings - Fork 165
Add Swarm support #484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Swarm support #484
Conversation
|
We might need to run this test separately, because we already initialise a swarm for some other tests.
Looks good otherwise! |
|
Hello @fussybeaver, how do you suggest we run this test separately? |
Hey, we probably need to exclude the test case from the default test run using a new test specific feature, and add a section in the CircleCI configuration. An example of this is the version tests in https://github.com/fussybeaver/bollard/blob/master/tests%2Fversion_test.rs |
23f937b to
e636fbe
Compare
|
@fussybeaver thanks for updating the tests. I hadn't had a chance to do it yet. |
|
Good to merge, I'll see if I can find time to release, but I'm fairly snowed under with the day job. |
| - run: resources/dockerfiles/bin/run_integration_tests.sh --features time --tests | ||
| test_swarm: | ||
| docker: | ||
| - image: docker:27.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can Dependabot be enabled? The latest release is 28.1.
No description provided.