Skip to content

Conversation

@tomasro27
Copy link

No description provided.

@fussybeaver
Copy link
Owner

fussybeaver commented Nov 21, 2024

We might need to run this test separately, because we already initialise a swarm for some other tests.

Looks good otherwise!

@tomasro27
Copy link
Author

Hello @fussybeaver, how do you suggest we run this test separately?

@fussybeaver
Copy link
Owner

fussybeaver commented Dec 4, 2024

Hello @fussybeaver, how do you suggest we run this test separately?

Hey, we probably need to exclude the test case from the default test run using a new test specific feature, and add a section in the CircleCI configuration.

An example of this is the version tests in https://github.com/fussybeaver/bollard/blob/master/tests%2Fversion_test.rs

@fussybeaver fussybeaver force-pushed the master branch 2 times, most recently from 23f937b to e636fbe Compare December 11, 2024 07:21
@tomasro27
Copy link
Author

@fussybeaver thanks for updating the tests. I hadn't had a chance to do it yet.
If everything looks good, we can check in, and let me know if we can do a release with this. It is very much appreciated

@fussybeaver fussybeaver merged commit dabf5ae into fussybeaver:master Dec 11, 2024
1 check passed
@fussybeaver
Copy link
Owner

Good to merge, I'll see if I can find time to release, but I'm fairly snowed under with the day job.

- run: resources/dockerfiles/bin/run_integration_tests.sh --features time --tests
test_swarm:
docker:
- image: docker:27.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can Dependabot be enabled? The latest release is 28.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants