Skip to content

release(1.1.6): clean logs#535

Merged
sebastienfontaine merged 4 commits into
masterfrom
release/1.1.6
Feb 9, 2026
Merged

release(1.1.6): clean logs#535
sebastienfontaine merged 4 commits into
masterfrom
release/1.1.6

Conversation

@sebastienfontaine

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Feb 9, 2026

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 56.06% 564 / 1006
🔵 Statements 56.38% 592 / 1050
🔵 Functions 62.92% 112 / 178
🔵 Branches 50.95% 268 / 526
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/common/debugLog.ts 40% 50% 33.33% 40% 10-14, 19
src/common/storage.ts 63.75% 43.2% 77.77% 63.94% 16-61, 71, 102, 117, 136-137, 151-152, 176, 185-186, 240-241, 318-408
Generated in workflow #438 for commit fb71326 by the Vitest Coverage Report Action

@greptile-apps

greptile-apps Bot commented Feb 9, 2026

Copy link
Copy Markdown

Greptile Overview

Greptile Summary

This PR bumps the extension/package version to 1.1.6 and reduces noisy logging by routing several storage-related console.log calls through debugLog().

Main concern: src/common/storage.ts now imports src/content/debugLog.ts, which is a content-script-oriented module that installs a chrome.storage.onChanged listener and itself imports _getStorageAsync from storage.ts. That cross-context dependency can lead to unexpected background/options behavior and introduces a circular dependency risk.

Confidence Score: 4/5

  • Mostly safe, but there is a real risk of cross-context/circular dependency issues due to importing a content-script debug module into shared storage code.
  • Version bumps are straightforward, and the logging cleanup is low-impact. The main risk is architectural: src/common/storage.ts now depends on src/content/debugLog.ts, which installs listeners and imports storage again, creating an unnecessary coupling that can break builds or produce unexpected side effects in non-content contexts.
  • src/common/storage.ts

Important Files Changed

Filename Overview
manifest.json Bumped extension version from 1.1.5 to 1.1.6.
package.json Bumped npm package version from 1.1.5 to 1.1.6.
src/common/storage.ts Replaced several console.log calls with debugLog; however storage.ts now imports a content-script debug module, which can cause cross-context bundling/circular-dependency issues.

Sequence Diagram

sequenceDiagram
  participant Any as Background/Options/etc
  participant Storage as src/common/storage.ts
  participant Debug as src/content/debugLog.ts
  participant Local as chrome.storage.local
  participant Sync as chrome.storage.sync

  Any->>Storage: _getStorageAsync()
  Storage->>Local: get(metadata + keys)
  alt found in local
    Storage-->>Any: TabModifierSettings
  else not found
    Storage->>Debug: debugLog("No data... checking sync")
    Storage->>Sync: get(metadata + keys)
    alt found in sync
      Storage->>Debug: debugLog("Migrating...")
      Storage->>Storage: _setStorage(data)
      Storage->>Debug: debugLog("Saving...")
      Storage->>Local: set(STORAGE_KEY_COMPRESSED)
      Storage->>Sync: remove(migration keys)
      Storage-->>Any: TabModifierSettings
    else not found
      Storage-->>Any: undefined
    end
  end

  Note over Debug: initDebugMode() installs onChanged listener
  Debug->>Local: onChanged listener triggers
  Debug->>Storage: _getStorageAsync() (reload settings)
Loading

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@greptile-apps

greptile-apps Bot commented Feb 9, 2026

Copy link
Copy Markdown
Additional Comments (1)

src/common/storage.ts
Cross-context debug import
src/common/storage.ts is shared code (used by background/options/etc), but it now imports ../content/debugLog.ts (storage.ts:5). That file registers a chrome.storage.onChanged listener and is content-script-specific by its own header comment; bundling this into non-content contexts can cause build/runtime issues (or at least unexpected listeners in background/options) and also creates a dependency cycle risk (debugLog.ts imports _getStorageAsync from storage). Consider moving the logging helper to a context-agnostic module (no listeners) or keep storage.ts using a plain logger and let content scripts wrap it.

@github-actions

github-actions Bot commented Feb 9, 2026

Copy link
Copy Markdown

📦 Extension Build Ready!

Version: 1.1.6

📥 Download Extension (tabee.zip)

Installation

  1. Download and extract the zip file
  2. Open Chrome → chrome://extensions/
  3. Enable "Developer mode" (top right)
  4. Click "Load unpacked" → Select the extracted folder

Status

  • ✅ All tests passed
  • ✅ Build successful
  • ✅ Ready for testing

🤖 Auto-generated by GitHub Actions

@sebastienfontaine sebastienfontaine merged commit 06c4681 into master Feb 9, 2026
6 checks passed
@sebastienfontaine sebastienfontaine deleted the release/1.1.6 branch February 9, 2026 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant